From 19c983beeb2cf5a1d2049ce73f587cbd904fedf2 Mon Sep 17 00:00:00 2001 From: RyanSwanson Date: Fri, 31 Jan 2025 11:20:32 -0700 Subject: [PATCH] fix: fix host to virtual service selector syncing (cherry picked from commit 6e32156aa67ccb3c32974bfb7d692923a59d957f) --- pkg/controllers/resources/services/syncer.go | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/pkg/controllers/resources/services/syncer.go b/pkg/controllers/resources/services/syncer.go index 340f9de038..6faa6abdd4 100644 --- a/pkg/controllers/resources/services/syncer.go +++ b/pkg/controllers/resources/services/syncer.go @@ -203,10 +203,9 @@ func (s *serviceSyncer) Sync(ctx *synccontext.SyncContext, event *synccontext.Sy } // translate selector - // TODO: ryan - convert to bidirectional - if !apiequality.Semantic.DeepEqual(event.VirtualOld.Spec.Selector, event.Virtual.Spec.Selector) || apiequality.Semantic.DeepEqual(event.HostOld.Spec.Selector, event.Host.Spec.Selector) { + if !apiequality.Semantic.DeepEqual(event.VirtualOld.Spec.Selector, event.Virtual.Spec.Selector) { event.Host.Spec.Selector = translate.HostLabelsMap(event.Virtual.Spec.Selector, event.Host.Spec.Selector, event.Virtual.Namespace, false) - } else { + } else if !apiequality.Semantic.DeepEqual(event.HostOld.Spec.Selector, event.Host.Spec.Selector) { event.Virtual.Spec.Selector = translate.VirtualLabelsMap(event.Host.Spec.Selector, event.Virtual.Spec.Selector) }