Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please fix Go module definition #27

Closed
vgough opened this issue May 26, 2024 · 3 comments
Closed

Please fix Go module definition #27

vgough opened this issue May 26, 2024 · 3 comments

Comments

@vgough
Copy link

vgough commented May 26, 2024

go.mod defines the package via module logdy when it should be module github.com/logdyhq/logdy-core. Attempting to import it from another module then results in an error:

        github.com/logdyhq/logdy-core/ring: github.com/logdyhq/logdy-core@v0.11.0: parsing go.mod:
        module declares its path as: logdy
                but was required as: github.com/logdyhq/logdy-core
@PeterOsinski
Copy link
Contributor

Hi, thanks for calling that in, I'll look into that. Can I ask about your use case of importing Logdy from another module? I was thinking about making it easier to embed Logdy into a Go app.

@vgough
Copy link
Author

vgough commented May 29, 2024

I found your ring package in a Google search, which looked like a clean implementation of a typed ring buffer, so I was going to try it. However I found that I wanted to clean up with API a bit (eg, replace most error result types with bool), so it probably makes more sense to fork it anyway. Unless you are open to considering contribution PRs?

@vgough
Copy link
Author

vgough commented Jun 10, 2024

I don't need this anymore, closing.

@vgough vgough closed this as completed Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants