Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts fail to install when using ArgoCD .. should not use lookup function #153

Closed
cfsnate opened this issue Aug 13, 2024 · 2 comments
Closed
Labels

Comments

@cfsnate
Copy link

cfsnate commented Aug 13, 2024

After debugging for some time, I've realized these charts use the lookup function when using a userDefinedSecret to get the secret data to be used in other chart logic. This generally goes against helm best practices and is entirely unsupported in systems like ArgoCD for GitOps managed clusters.

argoproj/argo-cd#5202

Proposed solution:
If the customer is using userDefinedSecret, assume the secret values are correct to render the helm chart. Don't have logic in the chart that depends on the lookup function to contact the k8s API.

Copy link

This Issue has been automatically marked as "stale" because it has not had recent activity (for 15 days). It will be closed if no further activity occurs. Thanks for the feedback.

@github-actions github-actions bot added the Stale label Aug 29, 2024
Copy link

github-actions bot commented Sep 4, 2024

Due to the lack of activity in the last 5 days since it was marked as "stale", we proceed to close this Issue. Do not hesitate to reopen it later if necessary.

@github-actions github-actions bot closed this as completed Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant