Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

setBulkOptions not working for lingerMs #27

Open
adrienbu opened this issue May 4, 2018 · 1 comment
Open

setBulkOptions not working for lingerMs #27

adrienbu opened this issue May 4, 2018 · 1 comment

Comments

@adrienbu
Copy link

adrienbu commented May 4, 2018

The lingerMs option is not working when using setBulkOptions.

Indeed, when using it, it sets the varaiable _bulkLingerMs. However, the only moment this variable is used is at script first launch

var _lingerManager = createLingerManager(_bulkLingerMs);

We should drop this parameter when creating the manager and instead use the global _bulkLingerMs variable.

@adrienbu
Copy link
Author

adrienbu commented May 4, 2018

Note: This can be easily tested from your html test page by setting the lingerMs option to 10000. Log is still sent about half a second after button click instead of 10s.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant