-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sampling Test Fix: Resubmission of #858 #917
base: chore-da-behavior-membership-tests
Are you sure you want to change the base?
Sampling Test Fix: Resubmission of #858 #917
Conversation
Hi @TakeASwing-420, what makes you think "committing to this branch will be good as of now(instead of the master branch)"? Do you have ideas how to resolve #902 ? Rather comment in #819 please. I can correct my test and learn myself. |
I want to actually change some code(The signal indicator) of my original #858 . But that's really not all, I thought this branch is dedicated for da behavior testing...so I thought commiting to this one would be convenient for you. |
Hey actually I could not reply properly as I was not in home. |
@danielSanchezQ reverted to original sampling test fix |
@romanzac @danielSanchezQ
I think committing to this branch will be good as of now(instead of the master branch). Currently, the specs of this PR is same that of #858.
I also intend to contribute on #819 (could not resist myself😋 after seeing that red labels on #900 and #902) in this same PR.