Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sampling Test Fix: Resubmission of #858 #917

Open
wants to merge 10 commits into
base: chore-da-behavior-membership-tests
Choose a base branch
from

Conversation

TakeASwing-420
Copy link
Contributor

@TakeASwing-420 TakeASwing-420 commented Nov 9, 2024

@romanzac @danielSanchezQ
I think committing to this branch will be good as of now(instead of the master branch). Currently, the specs of this PR is same that of #858.
I also intend to contribute on #819 (could not resist myself😋 after seeing that red labels on #900 and #902) in this same PR.

@TakeASwing-420 TakeASwing-420 marked this pull request as draft November 10, 2024 19:35
@romanzac
Copy link
Contributor

Hi @TakeASwing-420, what makes you think "committing to this branch will be good as of now(instead of the master branch)"? Do you have ideas how to resolve #902 ? Rather comment in #819 please. I can correct my test and learn myself.

@TakeASwing-420
Copy link
Contributor Author

TakeASwing-420 commented Nov 11, 2024

I want to actually change some code(The signal indicator) of my original #858 . But that's really not all, I thought this branch is dedicated for da behavior testing...so I thought commiting to this one would be convenient for you.

@TakeASwing-420
Copy link
Contributor Author

I want to actually change some code(The signal indicator) of my original #858 . But that's really not all, I thought this branch is dedicated for da behavior testing...so I thought commiting to this one would be convenient for you.

Hey actually I could not reply properly as I was not in home.
Replying to the 2nd concern, I am trying to fix that issue #902 ...I need some more time.
As you have said, from now I will write any findings regarding this in #902 itself.
But as I am committing in my GitHub repo the commit history will appear in this PR...

@TakeASwing-420 TakeASwing-420 marked this pull request as ready for review November 12, 2024 16:44
@TakeASwing-420
Copy link
Contributor Author

@danielSanchezQ reverted to original sampling test fix

@TakeASwing-420 TakeASwing-420 changed the title resubmission of #858 Sampling Test Fix: Resubmission of #858 Nov 12, 2024
@TakeASwing-420 TakeASwing-420 removed their assignment Nov 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants