Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Error if no feed item #1

Open
coolacid opened this issue Oct 10, 2014 · 3 comments
Open

[Bug] Error if no feed item #1

coolacid opened this issue Oct 10, 2014 · 3 comments

Comments

@coolacid
Copy link
Contributor

coolacid commented Oct 10, 2014

If there is zero feed items the plugin will error out

@coolacid coolacid added the bug label Oct 10, 2014
@abaykal
Copy link

abaykal commented Jun 11, 2015

This is still the issue with the version 1.4. if I have multiple input feeds in one config file for multiple feeds, if one of the feeds is empty, the entire plugin crashes.

@colinsurprenant
Copy link
Contributor

old issues followup: this definitely like a breaking condition which renders the plugin somewhat unusable which is also easy to fix.

@purbon purbon self-assigned this May 12, 2016
@purbon
Copy link

purbon commented May 12, 2016

I tested this behaviour with

<?xml version="1.0" encoding="windows-1252"?>
<rss version="2.0">
  <channel>
    <title>Sample Feed - Favorite RSS Related Software &amp; Resources</title>
    <description>Take a look at some of FeedForAll&apos;s favorite software and resources for learning more about RSS.</description>
    <link>http://www.feedforall.com</link>
    <category domain="www.dmoz.com">Computers/Software/Internet/Site Management/Content Management</category>
    <copyright>Copyright 2004 NotePage, Inc.</copyright>
    <docs>http://blogs.law.harvard.edu/tech/rss</docs>
    <language>en-us</language>
    <lastBuildDate>Mon, 1 Nov 2004 13:17:17 -0500</lastBuildDate>
    <managingEditor>marketing@feedforall.com</managingEditor>
    <pubDate>Tue, 26 Oct 2004 14:06:44 -0500</pubDate>
    <webMaster>webmaster@feedforall.com</webMaster>
    <generator>FeedForAll Beta1 (0.0.1.8)</generator>
    <image>
      <url>http://www.feedforall.com/feedforall-temp.gif</url>
      <title>FeedForAll Sample Feed</title>
      <link>http://www.feedforall.com/industry-solutions.htm</link>
      <description>FeedForAll Sample Feed</description>
      <width>144</width>
      <height>117</height>
    </image>
  </channel>
</rss>

actually an empty feeds, but still with some description and the plugin is still up and working as of the current version.

what I do believe is that the problem is when the rss feed is not valid 'because

feed = RSS::Parser.parse(body)

is actually performing a validation and should be like this, if the feed document is not valid, we should log the error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants