Changed expected datatype of request_timeout_ms option to number
#222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robbavey
requested changes
Mar 13, 2019
There was a problem hiding this comment.
@arenard Thank you for your contribution - this is a good change.
I have some requests before we can merge and publish:
Currently this change does not work - this needs to_s in a similar way to this
Would you mind adding a test to make sure this works correctly?
Also, once this change is in place, we can do a patch release rather than a full major release - this is not a breaking change, and existing configurations will continue to work.
karenzone
reviewed
Mar 13, 2019
|
Hello, sorry for the delay, I got a newborn since then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.