From 4299daf1d344255cd62a4a1938c1b9cb30d98e7d Mon Sep 17 00:00:00 2001
From: Chenxi Zhao <homezcx616@gmail.com>
Date: Fri, 11 Jan 2019 05:53:57 -0800
Subject: [PATCH] fix memory leak in Rank (#31)

* fix memory leak in Rank

* merge fix into existing loop

* clean up examples first before pushing back to pool
---
 rlclientlib/vw_model/safe_vw.cc | 6 ++++--
 1 file changed, 4 insertions(+), 2 deletions(-)

diff --git a/rlclientlib/vw_model/safe_vw.cc b/rlclientlib/vw_model/safe_vw.cc
index 2bc5244efb4..6350887ba65 100644
--- a/rlclientlib/vw_model/safe_vw.cc
+++ b/rlclientlib/vw_model/safe_vw.cc
@@ -138,9 +138,11 @@ namespace reinforcement_learning {
       scores[i] = predictions[i].score;
     }
 
-    // push examples back into pool for re-use
-    for (auto&& ex : examples)
+    // clean up examples and push examples back into pool for re-use
+    for (auto&& ex : examples) {
+      ex->pred.a_s.delete_v();
       _example_pool.emplace_back(ex);
+    }
 
     // cleanup
     examples.delete_v();