From 6245ffcf04201170ca26aa527f71939fca5b08e6 Mon Sep 17 00:00:00 2001 From: ataymano <41013086+ataymano@users.noreply.github.com> Date: Wed, 16 Jan 2019 08:19:14 -0500 Subject: [PATCH] i_sender ownership fix (#33) * i_sender ownership fix * unit test fix Looks good. Thanks. --- rlclientlib/logger/preamble_sender.h | 2 +- unit_test/preamble_test.cc | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/rlclientlib/logger/preamble_sender.h b/rlclientlib/logger/preamble_sender.h index e9b8d55d365..b58100b3607 100644 --- a/rlclientlib/logger/preamble_sender.h +++ b/rlclientlib/logger/preamble_sender.h @@ -9,6 +9,6 @@ namespace reinforcement_learning { namespace logger { int send(const uint16_t msg_type, const buffer& db, api_status* status) override; int init(api_status* status) override; private: - i_sender* _sender; + std::unique_ptr _sender; }; }} diff --git a/unit_test/preamble_test.cc b/unit_test/preamble_test.cc index 6f3e33e62ec..507e2bc5f58 100644 --- a/unit_test/preamble_test.cc +++ b/unit_test/preamble_test.cc @@ -29,8 +29,8 @@ struct dummy_sender : i_sender { BOOST_AUTO_TEST_CASE(simple_preamble_usage) { std::shared_ptr db(new data_buffer()); - dummy_sender raw_data; - preamble_message_sender f_sender(&raw_data); + dummy_sender* raw_data = new dummy_sender(); + preamble_message_sender f_sender(raw_data); i_message_sender& sender = f_sender; db->set_body_endoffset(db->preamble_size()+db->body_capacity()); const auto send_msg_sz = db->body_filled_size(); @@ -38,7 +38,7 @@ BOOST_AUTO_TEST_CASE(simple_preamble_usage) { sender.send(send_msg_type, db); preamble pre; - pre.read_from_bytes(raw_data.v_data->preamble_begin(), raw_data.v_data->preamble_size()); + pre.read_from_bytes(raw_data->v_data->preamble_begin(), raw_data->v_data->preamble_size()); BOOST_CHECK_EQUAL(pre.msg_size, send_msg_sz); BOOST_CHECK_EQUAL(pre.msg_type, send_msg_type);