Proper way to localize Bonfire

[dgvirtual]

I am working on improving localization of Bonfire. And I am thinking of the proper way to do that.

The strings from themes should obviously go to the general Language/en/Bonfire.php language file. So should perhaps the most common button names and messages - those that are repeated across the modules.

Then, each module should have it's own language files.

But I got stuck with Tools. What was uncommon - I found one language file there already, Logs.php language file. So, should there be a separate language file for Logs, SystemInfo, and also a separate file for the more general stuff (residing in the Module.php file)? So, three files for one module?

This fragmentation got me thinking that perhaps there should only be one language file for all of the Bonfire...

Could @lonnieezell drop a comment here?

[lonnieezell]

Thanks for working on this!

Yeah, tools was a bit of a mish-mash, and could perhaps be split up more. The original intent was for each module to remain as separate from the others as possible. The log viewer was actually written by someone else. For Tools, I would have a single language file to keep it consistent with the original intent.

And then a single Bonfire language file for all of the common strings is perfect.

[dgvirtual]

OK, so I guess I have your permission to rename Logs.php to Tools.php and update it with new strings... Also please see my latest commit - I wonder if the solution I presented for translating table heading column names that are originally derived from DB table fields is acceptable.

[lonnieezell]

Just approved and merged that one.

And yes, your suggestion works!

[dgvirtual]

As we talk about each module being self-sufficient - I would suggest moving the file
themes/Admin/Search/users.php
to the Users module Views directory (accordingly, also changing reference to it in Users/SearchProvider.php method resultView() ?
and also renaming it to something like _search_list.php ?

It seems to be a more appropriate place for it (also when it comes to localization, the language strings for it go more appropriately to the Users/Language/*/Users.php )

[lonnieezell]

That's one awkwardness about the current theme system, honestly - in order for people to easily modify the theme, the files should live in the appropriate themes directory. So that file was placed in the theme because it is a piece of the UI I could see different themes wanting to approach differently.

[dgvirtual]

ok, so, unless some outside-the-box solution is found, this will stay as it is, right?

[lonnieezell]

Correct.