Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

- Fix user settings #43

Merged
merged 11 commits into from
Dec 21, 2021
Merged

- Fix user settings #43

merged 11 commits into from
Dec 21, 2021

Conversation

atsanna
Copy link
Contributor

@atsanna atsanna commented Dec 15, 2021

I noticed that the administrative page for user settings does not save the settings - I think I have solved the problem

- Composer Style
@lonnieezell
Copy link
Owner

This looks to have some conflicts. Can you resolve those, please?

@atsanna
Copy link
Contributor Author

atsanna commented Dec 16, 2021

Sorry, it should be fine now :)

@lonnieezell
Copy link
Owner

Did you run composer style on this? It's changing everything from spaces to tabs and I'm pretty sure the settings in the style fixer should be spaces.

Either way, please use spaces for this project.

@atsanna
Copy link
Contributor Author

atsanna commented Dec 20, 2021

Did you run composer style on this? It's changing everything from spaces to tabs and I'm pretty sure the settings in the style fixer should be spaces.

Either way, please use spaces for this project.

I am running composer style multiple times before each commit.
I run compose style until the command line returns this message.

~/Documenti/Projects/atsanna_bonfire2$ composer style
> php-cs-fixer fix --verbose --ansi --using-cache=no
PHP CS Fixer 3.3.2 Trinacria by Fabien Potencier and Dariusz Ruminski
Runtime: PHP 8.0.8
Loaded config CodeIgniter4 Coding Standards from "/home/antonio/Documenti/Projects/atsanna_bonfire2/.php-cs-fixer.dist.php".
...............................................................................................................................................
Legend: ?-unknown, I-invalid file syntax (file ignored), S-skipped (cached or empty file), .-no changes, F-fixed, E-error

Fixed all files in 1.832 seconds, 16.000 MB memory used
antonio@HP-ZBook-15-G6:~/Documenti/Projects/atsanna_bonfire2$ 

I started using PhpStorm 2021.3 running on Ubuntu 20.10 a few months ago: I will try to check if by chance there is some setting that ruins everything ...

@atsanna
Copy link
Contributor Author

atsanna commented Dec 20, 2021

I think I found a setting in the editor where the tab character was set.

I hope I have solved the problem.

I tried to manually fix all files that used tab.

Sorry for that.

@lonnieezell
Copy link
Owner

No worries. thanks for this! Merging

@lonnieezell lonnieezell merged commit e5eb785 into lonnieezell:develop Dec 21, 2021
@atsanna atsanna deleted the user-settings branch December 21, 2021 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants