From 3320732b14a92c66d26ec307349b13248a2a9383 Mon Sep 17 00:00:00 2001
From: John Kaster <kaster@google.com>
Date: Wed, 3 Nov 2021 22:53:40 +0000
Subject: [PATCH] PR feedback

---
 .../components/ProjectViewDialog/ProjectViewDialog.tsx    | 8 +++++---
 .../JudgingEditorScene/components/JudgingViewDialog.tsx   | 8 +++++---
 .../src/scenes/JudgingScene/components/JudgingList.tsx    | 2 +-
 .../src/scenes/ProjectsScene/components/ProjectList.tsx   | 2 +-
 .../src/scenes/ProjectsScene/components/ProjectView.tsx   | 2 +-
 .../src/scenes/ProjectsScene/components/index.ts          | 2 +-
 packages/hackathon/src/scenes/index.ts                    | 1 +
 .../src/scenes/{ProjectsScene/components => }/utils.ts    | 2 +-
 8 files changed, 16 insertions(+), 11 deletions(-)
 rename packages/hackathon/src/scenes/{ProjectsScene/components => }/utils.ts (96%)

diff --git a/packages/hackathon/src/components/ProjectViewDialog/ProjectViewDialog.tsx b/packages/hackathon/src/components/ProjectViewDialog/ProjectViewDialog.tsx
index b26fc8e9e..a9b141215 100644
--- a/packages/hackathon/src/components/ProjectViewDialog/ProjectViewDialog.tsx
+++ b/packages/hackathon/src/components/ProjectViewDialog/ProjectViewDialog.tsx
@@ -31,16 +31,18 @@ import type { IProjectProps } from '../../models'
 import { ProjectView } from '../../scenes'
 
 interface ProjectViewDialogProps {
+  /** if assigned, dialog appears. If undefined, dialog is hidden */
   project?: IProjectProps
-  closer: () => void
+  /** Dialog closing event handler */
+  onClose: () => void
 }
 
 export const ProjectViewDialog: FC<ProjectViewDialogProps> = ({
   project,
-  closer,
+  onClose,
 }) => {
   const closeDialog = () => {
-    closer()
+    onClose()
   }
 
   return (
diff --git a/packages/hackathon/src/scenes/JudgingEditorScene/components/JudgingViewDialog.tsx b/packages/hackathon/src/scenes/JudgingEditorScene/components/JudgingViewDialog.tsx
index 7f50f5681..3397169bd 100644
--- a/packages/hackathon/src/scenes/JudgingEditorScene/components/JudgingViewDialog.tsx
+++ b/packages/hackathon/src/scenes/JudgingEditorScene/components/JudgingViewDialog.tsx
@@ -30,16 +30,18 @@ import type { IJudgingProps } from '../../../models'
 import { JudgingView } from './JudgingView'
 
 interface JudgingViewDialogProps {
+  /** If assigned, Dialog appears. If undefined, dialog closes */
   judging?: IJudgingProps
-  closer: () => void
+  /** Dialog closing event handler */
+  onClose: () => void
 }
 
 export const JudgingViewDialog: FC<JudgingViewDialogProps> = ({
   judging,
-  closer,
+  onClose,
 }) => {
   const closeDialog = () => {
-    closer()
+    onClose()
   }
 
   return (
diff --git a/packages/hackathon/src/scenes/JudgingScene/components/JudgingList.tsx b/packages/hackathon/src/scenes/JudgingScene/components/JudgingList.tsx
index 7d1f89359..13779bdc4 100644
--- a/packages/hackathon/src/scenes/JudgingScene/components/JudgingList.tsx
+++ b/packages/hackathon/src/scenes/JudgingScene/components/JudgingList.tsx
@@ -136,7 +136,7 @@ export const JudgingList: FC<JudgingListProps> = () => {
         pages={totalPages}
         onChange={updatePage}
       />
-      <JudgingViewDialog judging={currentJudging} closer={closeView} />
+      <JudgingViewDialog judging={currentJudging} onClose={closeView} />
     </>
   )
 }
diff --git a/packages/hackathon/src/scenes/ProjectsScene/components/ProjectList.tsx b/packages/hackathon/src/scenes/ProjectsScene/components/ProjectList.tsx
index 5dad58e1c..6e1730a71 100644
--- a/packages/hackathon/src/scenes/ProjectsScene/components/ProjectList.tsx
+++ b/packages/hackathon/src/scenes/ProjectsScene/components/ProjectList.tsx
@@ -204,7 +204,7 @@ export const ProjectList: FC<ProjectListProps> = () => {
         pages={totalPages}
         onChange={(pageNumber) => dispatch(updateProjectsPageNum(pageNumber))}
       />
-      <ProjectViewDialog project={currentProject} closer={closeView} />
+      <ProjectViewDialog project={currentProject} onClose={closeView} />
     </>
   )
 }
diff --git a/packages/hackathon/src/scenes/ProjectsScene/components/ProjectView.tsx b/packages/hackathon/src/scenes/ProjectsScene/components/ProjectView.tsx
index 8c3c6497e..e426faf34 100644
--- a/packages/hackathon/src/scenes/ProjectsScene/components/ProjectView.tsx
+++ b/packages/hackathon/src/scenes/ProjectsScene/components/ProjectView.tsx
@@ -30,7 +30,7 @@ import { useSelector } from 'react-redux'
 import type { IProjectProps } from '../../../models'
 import { ExtMarkdown } from '../../../components'
 import { getTechnologies } from '../../../data/hack_session/selectors'
-import { getMembers, techDescriptions } from './utils'
+import { getMembers, techDescriptions } from '../../utils'
 
 interface ProjectViewProps {
   project: IProjectProps
diff --git a/packages/hackathon/src/scenes/ProjectsScene/components/index.ts b/packages/hackathon/src/scenes/ProjectsScene/components/index.ts
index a3195372d..893fd31f0 100644
--- a/packages/hackathon/src/scenes/ProjectsScene/components/index.ts
+++ b/packages/hackathon/src/scenes/ProjectsScene/components/index.ts
@@ -26,4 +26,4 @@
 
 export * from './ProjectList'
 export * from './ProjectView'
-export * from './utils'
+export * from '../../utils'
diff --git a/packages/hackathon/src/scenes/index.ts b/packages/hackathon/src/scenes/index.ts
index 8543f3d43..c09bac6ec 100644
--- a/packages/hackathon/src/scenes/index.ts
+++ b/packages/hackathon/src/scenes/index.ts
@@ -33,3 +33,4 @@ export * from './AdminScene'
 export * from './NotFoundScene'
 export * from './ProjectEditorScene'
 export * from './ResourceScene'
+export * from './utils'
diff --git a/packages/hackathon/src/scenes/ProjectsScene/components/utils.ts b/packages/hackathon/src/scenes/utils.ts
similarity index 96%
rename from packages/hackathon/src/scenes/ProjectsScene/components/utils.ts
rename to packages/hackathon/src/scenes/utils.ts
index 039d1a7b3..702c039e0 100644
--- a/packages/hackathon/src/scenes/ProjectsScene/components/utils.ts
+++ b/packages/hackathon/src/scenes/utils.ts
@@ -24,7 +24,7 @@
 
  */
 
-import type { ITechnologyProps } from '../../../models'
+import type { ITechnologyProps } from '../models'
 
 export const techDescriptions = (
   ids: string[],