From a9f62bbac3280816d46756666d937d5543b61393 Mon Sep 17 00:00:00 2001 From: "Dr. Strangelove" Date: Mon, 14 Mar 2022 11:58:09 -0400 Subject: [PATCH] ci: change workflows to use reusable action for looker versions (#1018) * ci: change workflows to use reusable action for looker versions * fix: change supported-versions@v0.0.1 to @main Using a particular version here is a mistake since this would need to change for every new looker release. Instead use @main so that the supported-versions action will always use the latest version. --- .github/workflows/go-ci.yml | 10 +++++----- .github/workflows/python-ci.yml | 11 +++++------ .github/workflows/tssdk-ci.yml | 10 ++++------ 3 files changed, 14 insertions(+), 17 deletions(-) diff --git a/.github/workflows/go-ci.yml b/.github/workflows/go-ci.yml index d300921eb..f0d00ab30 100644 --- a/.github/workflows/go-ci.yml +++ b/.github/workflows/go-ci.yml @@ -64,8 +64,10 @@ jobs: name: ${{ env.JUNIT_ARTIFACT_DIR }} path: ${{ env.JUNIT_OUTPUT_DIR }} + setup: + uses: looker-open-source/reusable-actions/.github/workflows/supported-versions.yml@main integration: - needs: unit + needs: [setup,unit] name: Integration - ${{ matrix.os }} / Looker.${{ matrix.looker }} env: GO_JUNIT_OUTPUT_NAME: ${{ matrix.os }}.Looker-${{ matrix.looker }}.gointegration.xml @@ -78,10 +80,8 @@ jobs: matrix: os: - ubuntu - looker: - - '21_18' - - '21_20' - - '22_0' + looker: ${{ fromJson(needs.setup.outputs.matrix_json) }} + # TODO uncomment `include:` when either macos or windows works to satisfaction. #include: # TODO: macos matrix leg is functional but it takes ~20 minutes (compared diff --git a/.github/workflows/python-ci.yml b/.github/workflows/python-ci.yml index 7069c1ea5..515a3d407 100644 --- a/.github/workflows/python-ci.yml +++ b/.github/workflows/python-ci.yml @@ -94,8 +94,10 @@ jobs: name: python-test-results path: python/results/ + setup: + uses: looker-open-source/reusable-actions/.github/workflows/supported-versions.yml@main integration: - needs: unit + needs: [unit,setup] name: Integration - ${{ matrix.os }} / Looker.${{ matrix.looker }} env: TOX_JUNIT_OUTPUT_NAME: ${{ matrix.os }}.Looker-${{ matrix.looker }}.py3.x @@ -109,11 +111,8 @@ jobs: matrix: os: - ubuntu - looker: - - '21_18' - - '21_20' - - '22_0' - - '22_2' + looker: ${{ fromJson(needs.setup.outputs.matrix_json) }} + # TODO uncomment `include:` when either macos or windows works to satisfaction. #include: # TODO: macos matrix leg is functional but it takes ~20 minutes (compared diff --git a/.github/workflows/tssdk-ci.yml b/.github/workflows/tssdk-ci.yml index 2ab208c2d..bfafbcef2 100644 --- a/.github/workflows/tssdk-ci.yml +++ b/.github/workflows/tssdk-ci.yml @@ -105,8 +105,10 @@ jobs: name: tssdk-test-results path: results/tssdk + setup: + uses: looker-open-source/reusable-actions/.github/workflows/supported-versions.yml@main integration: - needs: unit + needs: [unit,setup] name: Integration - ${{ matrix.os }} / Node.${{ matrix.node-version }} / Looker.${{ matrix.looker }} env: JEST_JUNIT_OUTPUT_DIR: results/tssdk @@ -117,11 +119,7 @@ jobs: node-version: [12.x] os: - ubuntu - looker: - - '21_18' - - '21_20' - - '22_0' - - '22_2' + looker: ${{ fromJson(needs.setup.outputs.matrix_json) }} steps: - name: Repo Checkout