From c7648d9792bf976e2ea0ab0e94dfa0d45de83e66 Mon Sep 17 00:00:00 2001
From: ryandunlavy <32855869+ryandunlavy@users.noreply.github.com>
Date: Mon, 14 Aug 2023 16:12:55 -0700
Subject: [PATCH] fix: change visconfig types to reflect new getter (#1350)

* Fix types for VisualizationConfigImpl

---------

Co-authored-by: Ryan Dunlavy <rdunlavy@google.com>
---
 packages/extension-sdk/src/connect/visualization/types.ts     | 1 +
 .../src/connect/visualization/visualization_sdk.ts            | 4 ++--
 2 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/packages/extension-sdk/src/connect/visualization/types.ts b/packages/extension-sdk/src/connect/visualization/types.ts
index cf14ac9e7..f09f69282 100644
--- a/packages/extension-sdk/src/connect/visualization/types.ts
+++ b/packages/extension-sdk/src/connect/visualization/types.ts
@@ -98,6 +98,7 @@ export interface VisualizationConfig {
   queryFieldDimensions: Dimension[]
   queryFieldTableCalculations: TableCalculation[]
   queryFieldPivots: PivotConfig[]
+  visConfig: RawVisConfig
 }
 
 export interface QueryResponse {
diff --git a/packages/extension-sdk/src/connect/visualization/visualization_sdk.ts b/packages/extension-sdk/src/connect/visualization/visualization_sdk.ts
index 4c5d8f155..64a761667 100644
--- a/packages/extension-sdk/src/connect/visualization/visualization_sdk.ts
+++ b/packages/extension-sdk/src/connect/visualization/visualization_sdk.ts
@@ -92,8 +92,8 @@ class VisualizationConfigImpl implements VisualizationConfig {
     this._visConfig = visConfig
   }
 
-  get visConfig(): RawVisConfig | undefined {
-    return this._visConfig
+  get visConfig(): RawVisConfig {
+    return this._visConfig || {}
   }
 
   get queryFieldMeasures(): Measure[] {