Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: generate SDKs for Looker 23.6 #1293

Merged
merged 1 commit into from
Apr 11, 2023
Merged

feat: generate SDKs for Looker 23.6 #1293

merged 1 commit into from
Apr 11, 2023

Conversation

pfrisella
Copy link
Collaborator

Release-As: 23.6.0

👋👋 Thank you for contributing to Looker sdk-codegen (⚡️🍣)

📺 Watch a quick video on how to you make your pull requests fast and easy for you and your reviewer(s):
https://threadit.app/thread/k45nyrqugoinw6xub9vf/message/fl8m57exhqg4r0a4hg01eebn

  • 👆 Make sure your pull request title follows Pull Request Title Guidelines from our Contribution guide
  • 👉 Don't forget to replace these instructions with your ✨awesome✨ description of what this change actually does. Additionally, it's great to include context on how it works and why the change was needed.
  • 👇 Edit "Developer Checklist" to reflect items relevant to this PR (and try to make sure to check everything off before asking for review)

Developer Checklist ℹ️

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@github-actions
Copy link
Contributor

Python Tests

  10 files    10 suites   3m 53s ⏱️
144 tests 141 ✔️   3 💤 0 ❌
792 runs  780 ✔️ 12 💤 0 ❌

Results for commit c74152f.

@github-actions
Copy link
Contributor

Go Tests

    6 files      6 suites   15m 14s ⏱️
  50 tests   48 ✔️ 0 💤 2 ❌
120 runs  118 ✔️ 0 💤 2 ❌

For more details on these failures, see this check.

Results for commit c74152f.

@github-actions
Copy link
Contributor

Go Tests

    6 files      6 suites   13m 44s ⏱️
  50 tests   50 ✔️ 0 💤 0 ❌
120 runs  120 ✔️ 0 💤 0 ❌

Results for commit c74152f.

@github-actions
Copy link
Contributor

Typescript Tests

    6 files  ±0    56 suites  ±0   10m 17s ⏱️ -41s
200 tests ±0  196 ✔️ ±0    4 💤 ±0  0 ❌ ±0 
494 runs  ±0  478 ✔️ ±0  16 💤 ±0  0 ❌ ±0 

Results for commit c74152f. ± Comparison against base commit 6dcbd31.

Copy link
Collaborator

@jeremytchang jeremytchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pfrisella pfrisella merged commit dab9e0a into main Apr 11, 2023
@pfrisella pfrisella deleted the sdk_23_6 branch April 11, 2023 22:41
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants