feat: base class for all services #1295
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
josephaxisa
force-pushed
the
jax/item-list
branch
from
0d6ac63
to
1f6851a
Compare
zeckertG
previously approved these changes
Apr 12, 2023
jkaster
reviewed
Apr 12, 2023
| /** | ||
| * Creates an indexed collection from the cached items | ||
| */ | ||
| index(key: keyof T = this.keyField) { |
There was a problem hiding this comment.
love that you can set a default like this in TS
jkaster
approved these changes
Apr 12, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.