feat: added -n | --nostreams to code generator options #549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- for SDKs that support streaming, this skips generating the `streams` file. It does *not* remove any existing streams files, or change any other generated files - also expanded the `-h` display
- also support `all` as a language switch
joeldodge79
approved these changes
Apr 1, 2021
| langs.push(gen.language) | ||
| } | ||
| }) | ||
| if (values[0] !== 'all') { |
There was a problem hiding this comment.
I'm a little lost about how 'all' comes into play (both here and L103)
There was a problem hiding this comment.
it's possible someone may do, for example:
yarn -n allThere was a problem hiding this comment.
I could probably remove the premature optimization bit of 103, but it's such a corner case ...
bryans99
approved these changes
Apr 1, 2021
| yarn gen | ||
|
|
||
| # Generates Typescript and Python SDKs | ||
| yarn gen ts,py |
There was a problem hiding this comment.
so does it accept the file extension? I've been using yarn gen Typescript
There was a problem hiding this comment.
yup. extension, label, or language name matches. Added that a little while ago.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
streamsfile. It does not remove any existing streams files, or change any other generated files-hdisplay