Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add noComment toggle to code generators #627

Merged
merged 1 commit into from
Apr 23, 2021
Merged

Conversation

jkaster
Copy link
Contributor

@jkaster jkaster commented Apr 23, 2021

noComment defaults to false, retaining current generator behavior
noComment = true omits comments from code generation.
This option was primarily added for usage with API Explorer

Fixes #626 🦕

@github-actions

This comment has been minimized.

Copy link
Collaborator

@bryans99 bryans99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jkaster jkaster merged commit 90bbecb into main Apr 23, 2021
@jkaster jkaster deleted the jk/no_comment branch April 23, 2021 19:44
@github-actions
Copy link
Contributor

Test Results

  1 files   -     6    6 suites   - 67   29s ⏱️ - 3m 28s
58 tests  -   95  46 ✔️  - 107  12 💤 +12  0 ❌ ±0 
58 runs   - 477  46 ✔️  - 489  12 💤 +12  0 ❌ ±0 

Results for commit 90bbecb. ± Comparison against base commit c7b5bf8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a toggle for including comments in codegen
2 participants