Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: rendering of markdown tables in APIX explorer #687

Merged
merged 1 commit into from
May 20, 2021

Conversation

bryans99
Copy link
Collaborator

No description provided.

@github-actions
Copy link
Contributor

APIX Tests

    1 files    72 suites   2m 20s ⏱️
269 tests 257 ✔️ 12 💤 0 ❌
288 runs  276 ✔️ 12 💤 0 ❌

Results for commit 1a6ebae.

Copy link
Contributor

@jkaster jkaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix and the new test

Comment on lines +113 to +117
const { container } = renderWithTheme(<Markdown source={markdown} />)
expect(container.querySelector('th')?.innerHTML).toContain(
'Search Parameters'
)
expect(container.querySelector('td')?.innerHTML).toContain('begin_at')
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice test!

@bryans99 bryans99 merged commit 40e8640 into main May 20, 2021
@bryans99 bryans99 deleted the brynryans/fix-markdown-tables branch May 20, 2021 15:16
@github-actions

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants