fix: python datetime [de]serialization bug #734
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeldodge79
commented
Jul 2, 2021
|
|
||
|
|
||
| converter31.register_structure_hook(datetime.datetime, datetime_structure_hook) | ||
| converter40.register_structure_hook(datetime.datetime, datetime_structure_hook) | ||
| cattr.register_unstructure_hook(model.Model, unstructure_hook) # type: ignore | ||
| cattr.register_unstructure_hook(datetime.datetime, lambda dt: dt.strftime(DATETIME_FMT)) |
There was a problem hiding this comment.
this is the whole fix
| @@ -99,6 +99,7 @@ class Model(ml.Model): | |||
| # standard types | |||
| id: Optional[int] = None | |||
| name: Optional[str] = None | |||
| datetime_field: Optional[datetime.datetime] = None | |||
There was a problem hiding this comment.
adding this datetime_field everywhere in the tests identically reproduced the issue in #720
jkaster
approved these changes
Jul 2, 2021
| @@ -144,6 +144,7 @@ def unstructure_hook(api_model): | |||
| return data | |||
|
|
|||
|
|
|||
| DATETIME_FMT = "%Y-%m-%dT%H:%M:%S.%f%z" | |||
There was a problem hiding this comment.
Love the infinite syntax variation for datetime string formatting
Python Tests 10 files 10 suites 1m 55s ⏱️ Results for commit 5032ce4. |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we'd forgotten to register a
cattr.register_unstructure_hookfordatetime.datetimeobjects.Clearly no one had been trying to send in any data that included a datetime.datetime till now
closes #720