fix: bullet proof APIX response handling #754
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Description APIX now renders raw data if it cannot parse the response returned as expected. # Changes 1. Added try/catches in appropriate places. Note that the try/catch in RunIt is probably NOT necessary but the code being wrapped indicates that an error could be thrown (logically it should never happen as the user should always be authenticated). 2. Renamed `parseJson` method to `json2Csv` to better reflect what it does (I was initially confused by the original method name). 3. Created a ShowRaw response handler. 4. Created a fallbackResponseHandler to use ShowRaw.
jkaster
approved these changes
Jul 15, 2021
| 'The response body could not be parsed. Displaying raw data.' | ||
| ) | ||
| ).toBeInTheDocument() | ||
| expect(screen.getByText('I AM A LYING JSON RESPONSE')).toBeInTheDocument() |
| @@ -141,6 +137,21 @@ const ShowPDF = (response: IRawResponse) => { | |||
| return ShowUnknown(response) | |||
| } | |||
|
|
|||
| /** A handler for responses that cannot be parsed */ | |||
| const ShowRaw = (response: IRawResponse) => ( | |||
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
APIX now renders raw data if it cannot parse the response returned as expected.
Changes
parseJsonmethod tojson2Csvto better reflect what it does (I was initially confused by the original method name).Screen Shots