fix: intrinsic type params are not Partial<T> #819
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
codegen generates affected `body` parameters as `string` instead of `Partial<string>`.
jkaster
requested review from
bryans99,
joeldodge79,
drstrangelooker,
josephaxisa,
fabio-looker,
lanlooker and
jeremytchang
Codegen Tests 1 files 6 suites 56s ⏱️ Results for commit 870d12b. |
Typescript Tests 6 files 75 suites 3m 47s ⏱️ Results for commit 870d12b. |
Codegen Tests 1 files 6 suites 58s ⏱️ Results for commit c4e39fb. |
Typescript Tests 6 files 75 suites 4m 13s ⏱️ Results for commit c4e39fb. |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
codegen now generates affected
bodyparameters asstringinstead ofPartial<string>.Typically
bodyparameters are structures rather than simple (akaintrinsic) types like a string. While TypeScript correctly handlesPartial<string>this is confusing to the code reader, so this tweaks the generator to removePartial<*>wrapping of the type name for the body parameter on simple types.This PR uses Looker 21.14 specifications for the updated SDK code that got generated.