fix: Extension Api Explorer markdown link clicks #830
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clicking a link in markdown now works for extensions. Fix is to rely on getAttribute method to get pathname and href values rather than get pathname and href directly. Also, now tests if url begins with the spec key as well as the pathname. Possibly broken by markdown upgrade although why standalone was not broken is puzzling
bryans99
requested review from
jkaster,
josephaxisa,
fabio-looker and
jeremytchang
APIX Tests 1 files 77 suites 2m 24s ⏱️ Results for commit df90780. |
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clicking a link in markdown now works for extensions.
Fix is to rely on getAttribute method to get pathname and href values rather
than get pathname and href directly. Also, now tests if url begins with
the spec key as well as the pathname.
Possibly broken by markdown upgrade although why standalone was not
broken is puzzling