Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stack overflow for type tagging during codegen #845

Merged
merged 2 commits into from
Oct 5, 2021

Conversation

jkaster
Copy link
Contributor

@jkaster jkaster commented Oct 5, 2021

Change was made for APIX type tagging, and a scenario was missed that caused infinite recursion

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2021

Codegen Tests

  1 files    6 suites   58s ⏱️
58 tests 46 ✔️ 12 💤 0 ❌

Results for commit db568bc.

Copy link
Contributor

@josephaxisa josephaxisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@github-actions
Copy link
Contributor

github-actions bot commented Oct 5, 2021

Codegen Tests

  1 files    6 suites   1m 1s ⏱️
58 tests 46 ✔️ 12 💤 0 ❌

Results for commit 219dbb5.

@jkaster jkaster merged commit 4ece1b3 into main Oct 5, 2021
@jkaster jkaster deleted the jk/fix_type_tagging branch October 5, 2021 17:46
@github-actions

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants