-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: headless nav toggle #860
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo
Co-authored-by: John Kaster <kaster@google.com>
APIX Tests 1 files 80 suites 2m 56s ⏱️ Results for commit 2e5d1e2. |
APIX Tests 1 files 80 suites 2m 34s ⏱️ Results for commit 8de1160. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few small suggest, smaller sidebar on collapsed state and better centering when collapsed
Co-authored-by: Jared <hardy.jared@gmail.com>
Co-authored-by: Jared <hardy.jared@gmail.com>
APIX Tests 1 files 80 suites 3m 15s ⏱️ Results for commit dc81cda. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I put headless: true
in packages/api-explorer/public/versions.json
it displays correctly and works.
However, if I've configured a remote server to OAuth to, the headless: true
value is lost, no matter what I do, even if I hard code it. So there's something (probably not your fault) that is breaking it for its intended usage when embedded in the developer portal.
I just tested it locally and can confirm the same result but this PR does not touch that logic. I am seeing the same issue on sdk-codegen/packages/api-explorer/src/StandaloneApiExplorer.tsx Lines 105 to 110 in 31fe97c
Looking into this briefly I can see that on initial load we are reading versions from the statically served Perhaps the indicator of whether an instance of API Explorer is headless or not should be determined at the usage site by passing in the prop |
APIX Tests 1 files 80 suites 2m 55s ⏱️ Results for commit 8458409. |
…x/headless-nav-toggle
APIX Tests 1 files 80 suites 2m 54s ⏱️ Results for commit 8ead213. |
Added a toggle for when APIX is running in headless mode. Screenshots don't really help, I suggest trying this locally.