Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: enforce required body parameters for RunIt #883

Merged
merged 5 commits into from
Oct 29, 2021
Merged

Conversation

jkaster
Copy link
Contributor

@jkaster jkaster commented Oct 29, 2021

Body parameters that are required must be provided before RunIt will Run

Screenshot

image

josephaxisa
josephaxisa previously approved these changes Oct 29, 2021
Copy link
Contributor

@josephaxisa josephaxisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool addition, lgtm

Copy link
Contributor

@josephaxisa josephaxisa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still lgtm

@github-actions
Copy link
Contributor

APIX Tests

    1 files  ±0    79 suites  ±0   3m 26s ⏱️ +5s
324 tests +2  311 ✔️ +2  13 💤 ±0  0 ❌ ±0 
340 runs  +2  327 ✔️ +2  13 💤 ±0  0 ❌ ±0 

Results for commit e983fed. ± Comparison against base commit 02f0ea0.

@jkaster jkaster merged commit a4dfb3c into main Oct 29, 2021
@jkaster jkaster deleted the jk/required_body branch October 29, 2021 18:15
@github-actions

This comment has been minimized.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants