-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Hackathon styling and resource update #884
Conversation
- Updated Loading component to default to always display if not passed in loading prop. Making it as dumb as possible - Updated Loading rendering logic and styling in scene components so layouts does not shift/change after loading is finished. - Updated side nav to be thinner to accomodate smaller viewports - Updated resources with new component and dataset tag - Added header to each page for easier navigability - Added hacker faq link to home/agenda page - Added additional text and field styling to resource page for better UX
<Heading as="h2" fontSize="xxxlarge" fontWeight="medium"> | ||
Agenda | ||
</Heading> | ||
<Span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nested in span so the paragraph is not too far from Heading in SpaceVertical.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For v.next with artifact storage we'll schedule some design review too
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Totally. I'm pretty sure I'm not following design best practices here, only aiming for what looks good. Will appreciate their input.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Lots of nice little improvements. Good sweep.
<Heading as="h2" fontSize="xxxlarge" fontWeight="medium"> | ||
Agenda | ||
</Heading> | ||
<Span> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For v.next with artifact storage we'll schedule some design review too
passed in loading prop. Making it as dumb as possible
so layouts does not shift/change after loading is finished.
better UX