-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: judging view for Hackathon app #891
Conversation
packages/hackathon/src/scenes/JudgingEditorScene/components/JudgingViewDialog.tsx
Show resolved
Hide resolved
@@ -24,4 +24,28 @@ | |||
|
|||
*/ | |||
|
|||
export * from './ProjectView' | |||
import type { ITechnologyProps } from '../../../models' |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This file should be moved up a folder or two since its shared between projects and judging scene.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Thanks! Looks great! :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
Typically you dont need to comment the onClose
handler. Prefixing on
, pretty much means its an event handler. But thank you for heeding the feedback!
Added
Removed
Screenshots
Judging View
Project View