From 8589147169da96fbbf14b058228078d1d43f8036 Mon Sep 17 00:00:00 2001 From: Jeremy Chang Date: Thu, 24 Mar 2022 18:11:14 +0000 Subject: [PATCH] feat: Revert "Update release-please version, add r-p config for Go, add Go publish CI (#1030)" This reverts commit e597978f0c27eb5818e97e3c9426704948e0a6e6. --- .github/workflows/go-publish.yml | 40 ---------------------------- .github/workflows/release-please.yml | 2 +- .release-please-manifest.json | 3 +-- go/go.mod | 1 - go/go.sum | 16 ----------- release-please-config.json | 3 +-- 6 files changed, 3 insertions(+), 62 deletions(-) delete mode 100644 .github/workflows/go-publish.yml diff --git a/.github/workflows/go-publish.yml b/.github/workflows/go-publish.yml deleted file mode 100644 index 17baaf129..000000000 --- a/.github/workflows/go-publish.yml +++ /dev/null @@ -1,40 +0,0 @@ -name: Publish Go module to Go proxy -on: - release: - types: published - - workflow_dispatch: - inputs: - ref: - description: 'commit/tag/branch to release from' - required: true - -defaults: - run: - shell: bash - working-directory: go/ - -jobs: - publish: - if: > - (github.event.inputs) || - (startsWith(github.event.release.tag_name, 'go') && - !github.event.release.draft && - !github.event.release.prerelease) - runs-on: ubuntu-latest - steps: - - uses: actions/checkout@v2 - with: - ref: ${{ github.event.release.tag_name || github.event.inputs.ref }} - - - name: Install Go - uses: actions/setup-go@v2 - with: - go-version: '1.18' - - # Assumes tag_name is "go/vX.X.X" and splits off "go/"" - # `go list` only accepts version as "vX.X.X" - - name: Publish https://go.dev/doc/modules/publishing - run: | - version=$(echo ${{github.event.release.tag_name}} | cut -d/ -f2) - GOPROXY=proxy.golang.org go list -m github.com/looker-open-source/sdk-codegen/go@$version diff --git a/.github/workflows/release-please.yml b/.github/workflows/release-please.yml index b315d3993..03a85e1e8 100644 --- a/.github/workflows/release-please.yml +++ b/.github/workflows/release-please.yml @@ -8,7 +8,7 @@ jobs: release-please: runs-on: ubuntu-latest steps: - - uses: google-github-actions/release-please-action@v3 + - uses: google-github-actions/release-please-action@b1f383133aa4cc90eca1d35ae7ac7d96c1e83d72 with: command: manifest monorepo-tags: true diff --git a/.release-please-manifest.json b/.release-please-manifest.json index 07caf621b..c572630fd 100644 --- a/.release-please-manifest.json +++ b/.release-please-manifest.json @@ -15,6 +15,5 @@ "packages/sdk-node": "22.2.0", "packages/sdk-rtl": "21.3.1", "packages/wholly-sheet": "0.5.25", - "python": "22.2.1", - "go": "0.0.1" + "python": "22.2.1" } diff --git a/go/go.mod b/go/go.mod index 3a7303949..1c1dbb92a 100644 --- a/go/go.mod +++ b/go/go.mod @@ -4,6 +4,5 @@ go 1.14 require ( github.com/json-iterator/go v1.1.12 - github.com/smartystreets/goconvey v1.7.2 // indirect gopkg.in/ini.v1 v1.61.0 ) diff --git a/go/go.sum b/go/go.sum index c2f39fb63..23fb3dcd1 100644 --- a/go/go.sum +++ b/go/go.sum @@ -1,30 +1,14 @@ github.com/davecgh/go-spew v1.1.0/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= -github.com/davecgh/go-spew v1.1.1 h1:vj9j/u1bqnvCEfJOwUhtlOARqs3+rkHYY13jYWTU97c= github.com/davecgh/go-spew v1.1.1/go.mod h1:J7Y8YcW2NihsgmVo/mv3lAwl/skON4iLHjSsI+c5H38= github.com/google/gofuzz v1.0.0/go.mod h1:dBl0BpW6vV/+mYPU4Po3pmUjxk6FQPldtuIdl/M65Eg= -github.com/gopherjs/gopherjs v0.0.0-20181017120253-0766667cb4d1 h1:EGx4pi6eqNxGaHF6qqu48+N2wcFQ5qg5FXgOdqsJ5d8= -github.com/gopherjs/gopherjs v0.0.0-20181017120253-0766667cb4d1/go.mod h1:wJfORRmW1u3UXTncJ5qlYoELFm8eSnnEO6hX4iZ3EWY= github.com/json-iterator/go v1.1.12 h1:PV8peI4a0ysnczrg+LtxykD8LfKY9ML6u2jnxaEnrnM= github.com/json-iterator/go v1.1.12/go.mod h1:e30LSqwooZae/UwlEbR2852Gd8hjQvJoHmT4TnhNGBo= -github.com/jtolds/gls v4.20.0+incompatible h1:xdiiI2gbIgH/gLH7ADydsJ1uDOEzR8yvV7C0MuV77Wo= -github.com/jtolds/gls v4.20.0+incompatible/go.mod h1:QJZ7F/aHp+rZTRtaJ1ow/lLfFfVYBRgL+9YlvaHOwJU= github.com/modern-go/concurrent v0.0.0-20180228061459-e0a39a4cb421 h1:ZqeYNhU3OHLH3mGKHDcjJRFFRrJa6eAM5H+CtDdOsPc= github.com/modern-go/concurrent v0.0.0-20180228061459-e0a39a4cb421/go.mod h1:6dJC0mAP4ikYIbvyc7fijjWJddQyLn8Ig3JB5CqoB9Q= github.com/modern-go/reflect2 v1.0.2 h1:xBagoLtFs94CBntxluKeaWgTMpvLxC4ur3nMaC9Gz0M= github.com/modern-go/reflect2 v1.0.2/go.mod h1:yWuevngMOJpCy52FWWMvUC8ws7m/LJsjYzDa0/r8luk= -github.com/pmezard/go-difflib v1.0.0 h1:4DBwDE0NGyQoBHbLQYPwSUPoCMWR5BEzIk/f1lZbAQM= github.com/pmezard/go-difflib v1.0.0/go.mod h1:iKH77koFhYxTK1pcRnkKkqfTogsbg7gZNVY4sRDYZ/4= -github.com/smartystreets/assertions v1.2.0 h1:42S6lae5dvLc7BrLu/0ugRtcFVjoJNMC/N3yZFZkDFs= -github.com/smartystreets/assertions v1.2.0/go.mod h1:tcbTF8ujkAEcZ8TElKY+i30BzYlVhC/LOxJk7iOWnoo= -github.com/smartystreets/goconvey v1.7.2 h1:9RBaZCeXEQ3UselpuwUQHltGVXvdwm6cv1hgR6gDIPg= -github.com/smartystreets/goconvey v1.7.2/go.mod h1:Vw0tHAZW6lzCRk3xgdin6fKYcG+G3Pg9vgXWeJpQFMM= github.com/stretchr/objx v0.1.0/go.mod h1:HFkY916IF+rwdDfMAkV7OtwuqBVzrE8GR6GFx+wExME= -github.com/stretchr/testify v1.3.0 h1:TivCn/peBQ7UY8ooIcPgZFpTNSz0Q2U6UrFlUfqbe0Q= github.com/stretchr/testify v1.3.0/go.mod h1:M5WIy9Dh21IEIfnGCwXGc5bZfKNJtfHm1UVUgZn+9EI= -golang.org/x/crypto v0.0.0-20190308221718-c2843e01d9a2/go.mod h1:djNgcEr1/C05ACkg1iLfiJU5Ep61QUkGW8qpdssI0+w= -golang.org/x/net v0.0.0-20190311183353-d8887717615a/go.mod h1:t9HGtf8HONx5eT2rtn7q6eTqICYqUVnKs3thJo3Qplg= -golang.org/x/sys v0.0.0-20190215142949-d0b11bdaac8a/go.mod h1:STP8DvDyc/dI5b8T5hshtkjS+E42TnysNCUPdjciGhY= -golang.org/x/text v0.3.0/go.mod h1:NqM8EUOU14njkJ3fqMW+pc6Ldnwhi/IjpwHt7yyuwOQ= -golang.org/x/tools v0.0.0-20190328211700-ab21143f2384/go.mod h1:LCzVGOaR6xXOjkQ3onu1FJEFr0SW1gC7cKk1uF8kGRs= gopkg.in/ini.v1 v1.61.0 h1:LBCdW4FmFYL4s/vDZD1RQYX7oAR6IjujCYgMdbHBR10= gopkg.in/ini.v1 v1.61.0/go.mod h1:pNLf8WUiyNEtQjuu5G5vTm06TEv9tsIgeAvK8hOrP4k= diff --git a/release-please-config.json b/release-please-config.json index a08066b9a..6a955514f 100644 --- a/release-please-config.json +++ b/release-please-config.json @@ -20,7 +20,6 @@ "packages/sdk-node": { }, "packages/sdk-rtl": { "release-as": "" }, "packages/wholly-sheet": { "release-as": "" }, - "python": { "release-type": "python", "package-name": "looker_sdk" }, - "go": { "release-as": "", "release-type": "go", "package-name": "go", "tag-separator": "/" } + "python": { "release-type": "python", "package-name": "looker_sdk" } } }