From 62856f1f39c33fdba1ebbe18414329e313ef0d2d Mon Sep 17 00:00:00 2001 From: John Kaster Date: Thu, 11 Nov 2021 21:01:29 +0000 Subject: [PATCH 1/2] fix: make sheetCell always return a Span ``` now required an element` --- packages/hackathon/src/models/sheetUtils.tsx | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/hackathon/src/models/sheetUtils.tsx b/packages/hackathon/src/models/sheetUtils.tsx index 945b94ec5..58c55fe2c 100644 --- a/packages/hackathon/src/models/sheetUtils.tsx +++ b/packages/hackathon/src/models/sheetUtils.tsx @@ -25,7 +25,7 @@ */ import type { SheetValues } from '@looker/wholly-sheet' import type { DataTableColumn, DataTableColumns } from '@looker/components' -import { Icon } from '@looker/components' +import { Span, Icon } from '@looker/components' import { Done } from '@styled-icons/material/Done' import React from 'react' @@ -86,10 +86,10 @@ export const sheetHeader = (header: string[], row: any) => { * @param value to convert to displayable actionitem */ export const sheetCell = (value: any) => { - if (typeof value === 'undefined') return '' + if (typeof value === 'undefined') return if (typeof value === 'boolean') { - return value ? } /> : '' + return value ? } /> : } if (value instanceof Set) { @@ -98,10 +98,10 @@ export const sheetCell = (value: any) => { for (const v of value.values()) { values.push(v.toString()) } - return values.join(', ') + return {values.join(', ')} } if (value instanceof Date) { - return value.toDateString() + return {value.toDateString()} } - return value.toString() + return {value.toString()} } From a863568b5a339b2d999493d7b61e8374286cdd04 Mon Sep 17 00:00:00 2001 From: John Kaster Date: Thu, 11 Nov 2021 21:56:38 +0000 Subject: [PATCH 2/2] added youtu.be to manifest --- packages/hackathon/README.md | 1 + 1 file changed, 1 insertion(+) diff --git a/packages/hackathon/README.md b/packages/hackathon/README.md index 8f23b66de..de0cfcec0 100644 --- a/packages/hackathon/README.md +++ b/packages/hackathon/README.md @@ -38,6 +38,7 @@ application: hackathon { "https://*.slack.com/*", "https://*.github.com/*", "https://*.youtube.com/*", + "https://*.youtu.be/*", "https://*.vimeo.com/*" ] use_form_submit: yes