Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Format the code using prettier #165

Closed
9 tasks done
bajtos opened this issue Apr 18, 2017 · 5 comments
Closed
9 tasks done

Format the code using prettier #165

bajtos opened this issue Apr 18, 2017 · 5 comments
Assignees
Milestone

Comments

@bajtos
Copy link
Member

bajtos commented Apr 18, 2017

I'd like to open a discussion about the coding style we using in LoopBack Next and more specifically, about automatically formatting all our source code using Prettier.

Yes, I do realise Prettier does not support TypeScript yet, so this GH issue won't be actionable for a while.

What needs to be done:

@bajtos
Copy link
Member Author

bajtos commented Jun 1, 2017

An existing prettier alternative: https://github.com/vvakame/typescript-formatter

@bajtos
Copy link
Member Author

bajtos commented Jun 5, 2017

Prettier supports TypeScript now: https://github.com/prettier/prettier/releases/tag/1.4.0

@bajtos bajtos self-assigned this Jun 5, 2017
@bajtos
Copy link
Member Author

bajtos commented Aug 23, 2017

This task is basically blocked until prettier 1.6 is released (see prettier/prettier#2589) and the VS Code extension supports sharing prettier configuration via a config file (see prettier/prettier-vscode#124).

@bajtos
Copy link
Member Author

bajtos commented Aug 29, 2017

prettier@1.6.0 was released yesterday, a new version of prettier-vscode was released few minutes ago. We should be good to get this started!

@bajtos
Copy link
Member Author

bajtos commented Mar 2, 2018

Done 🎉 🎊

@bajtos bajtos closed this as completed Mar 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants