Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(code)!: change code to get closer to the template #37

Merged
merged 14 commits into from
Aug 25, 2024
Merged

refactor(code)!: change code to get closer to the template #37

merged 14 commits into from
Aug 25, 2024

Conversation

looztra
Copy link
Owner

@looztra looztra commented Aug 25, 2024 •
edited
Loading

Description

What this PR Provides

  • refactor the code to get something closer to the asdf-plugin-template code
  • add tests

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation
  • Chore (gha, tools, pre-commit)
  • Tests

Usage examples

How Has This Been Tested?

Checklist

  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.

@looztra looztra force-pushed the refactor/get-closer-to-template branch 11 times, most recently from e6d4476 to 2ccf50b Compare August 25, 2024 15:34
@looztra looztra force-pushed the refactor/get-closer-to-template branch from 2ccf50b to 1770ff2 Compare August 25, 2024 15:36
@looztra looztra force-pushed the refactor/get-closer-to-template branch from b061b1d to 499d1bf Compare August 25, 2024 17:45
@looztra looztra force-pushed the refactor/get-closer-to-template branch from 499d1bf to ebf1497 Compare August 25, 2024 17:48
@looztra looztra changed the title refactor(sh): change code to get closer to the template refactor!(sh): change code to get closer to the template Aug 25, 2024
@looztra looztra marked this pull request as ready for review August 25, 2024 17:54
@looztra looztra changed the title refactor!(sh): change code to get closer to the template refactor(code)!: change code to get closer to the template Aug 25, 2024
@looztra looztra merged commit b810a66 into main Aug 25, 2024
8 of 9 checks passed
@looztra looztra deleted the refactor/get-closer-to-template branch August 25, 2024 17:55
@looztra looztra mentioned this pull request Aug 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@looztra