Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use PSR-16 SimpleCacheInterface instead of CacheMapInterface #9

Open
acelot opened this issue May 7, 2019 · 3 comments
Open

Use PSR-16 SimpleCacheInterface instead of CacheMapInterface #9

acelot opened this issue May 7, 2019 · 3 comments

Comments

@acelot
Copy link

acelot commented May 7, 2019

This would improve interoperability and compatibility with third-party caching packages.
@enumag
Copy link
Contributor

enumag commented Oct 5, 2019

👎 PSR-16 is a synchronous API. Not suitable to be used in async applications with promises.

@acelot
Copy link
Author

acelot commented Oct 6, 2019

But I see, that CacheMapInterface doesn't use promises.

@enumag
Copy link
Contributor

enumag commented Oct 6, 2019

That's most likely a slight oversight of the author. I'm guessing he just implemented the simple in-memory CacheMap and added an interface as a good practice. But it didn't occur to him that different implementations would need to use promises.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@enumag @acelot