Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Integration test hook dependency test fails on R 4.4 #565

Closed
lorenzwalthert opened this issue May 19, 2024 · 1 comment · May be fixed by #584
Closed

Integration test hook dependency test fails on R 4.4 #565

lorenzwalthert opened this issue May 19, 2024 · 1 comment · May be fixed by #584

Comments

@lorenzwalthert
Copy link
Owner

In #564, hook dependency tests started failing, previously in #561, they did not. Reverting to oldrel in #564 temporarily with d6ecd65. It seems like the R profile might not be loaded when calling from R 4.4, but this needs further investigation.

Also, it's unclear if we still need these integration tests, as we have a catch-all integration test Python pre-commit, hook installation and calling in .github/workflows/end-to-end.yml.
@lorenzwalthert lorenzwalthert mentioned this issue May 22, 2024
Merged
@lorenzwalthert lorenzwalthert mentioned this issue Jul 22, 2024
Open
@lorenzwalthert
Copy link
Owner Author

And now, magic happens, it work again...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix hook tests lorenzwalthert/precommit
1 participant
@lorenzwalthert