-
Notifications
You must be signed in to change notification settings - Fork 976
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faraday::Adapter::NetHttpPersistent timeout tests failing with net-http-persistent 4.0.0 #1152
Comments
Here's all the failing tests:
|
Thanks @dgholz, yes that release got us by surprise, and it's mostly our fault for not pinning the correct version in the Gemfile. Let's see if we can add support to v4.0.0 without breaking support for v3.0.0 which I suspect is still widely used. I saw some PRs about this so will try to have a look over the next days. |
Fixed in #1156 |
Basic Info
Issue description
Hello, I just checked out master & ran the tests, and I see all the timeout-related tests in
spec/faraday/adapter/net_http_persistent_spec.rb
failing with stacktraces like:I see
net-http-persistent
just releasedv4.0.0
; when I pinnednet-http-persistent
to~> 3.0
in theGemfile
&bundle install
, the tests pass as expected.Steps to reproduce
The text was updated successfully, but these errors were encountered: