Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test failures with 0.5.3 #128

Closed
CosmicToast opened this issue Feb 20, 2019 · 3 comments
Closed

Test failures with 0.5.3 #128

CosmicToast opened this issue Feb 20, 2019 · 3 comments

Comments

@CosmicToast
Copy link

CosmicToast commented Feb 20, 2019

I package skim on Alpine Linux (not in edge yet, too busy to get it through the pipeline).
Trying to bump 0.5.2 to 0.5.3 I get two test failures:

---- field::test::test_parse_field_range stdout ----
thread 'field::test::test_parse_field_range' panicked at 'assertion failed: `(left == right)`
  left: `Some((0, 0))`,
 right: `None`', src/field.rs:226:9
note: Run with `RUST_BACKTRACE=1` for a backtrace.

---- field::test::test_get_string_by_field stdout ----
thread 'field::test::test_get_string_by_field' panicked at 'assertion failed: `(left == right)`
  left: `Some("")`,
 right: `None`', src/field.rs:360:9


failures:
    field::test::test_get_string_by_field
    field::test::test_parse_field_range

Build Environment: see APKBUILD (this is still the old 0.5.2 one, I test my builds before committing)

I managed to reproduce this on Arch Linux amd64, so it isn't a musl issue.

EDIT: P.S. if/when this is fixed, it would help to have another release, so packagers don't have to disable tests for one release / incorporate temporary patches

@lotabout
Copy link
Collaborator

@5paceToast Sure! Thanks for report and I'll fix it ASAP.

@lotabout
Copy link
Collaborator

@5paceToast Done. please use v0.5.4.

@CosmicToast
Copy link
Author

Can confirm - tests now pass. Thanks 👍!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants