Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi selection including unselected option #210

Closed
tpoliaw opened this issue Aug 9, 2019 · 1 comment
Closed

Multi selection including unselected option #210

tpoliaw opened this issue Aug 9, 2019 · 1 comment

Comments

@tpoliaw
Copy link

tpoliaw commented Aug 9, 2019

$ sk --version
0.6.8

This might be intended behaviour but it caught me out by being different to fzf.
When using skim with the --multi flag, the line the cursor is on when you hit enter is included in the returned selection, even if it hasn't been selected. There are often times when I search/scroll through a list and find there are no more options that need selecting but would have to scroll back to the previous selection to prevent an unwanted option being included.

Is there an option to change this behaviour so that only explicitly selected items are selected?

@lotabout
Copy link
Collaborator

After the fix, skim behave like this:

  1. If multi-selection is not enabled, select current item
  2. If multi-selection is enabled
    a) No item is selected -> select current item
    b) already selected some items -> exclude current item

It should be compatible with fzf.

lotabout added a commit that referenced this issue Jan 27, 2020
fix #210: exclude current item in multi-selection
makovich pushed a commit to makovich/skim that referenced this issue May 28, 2020
Be compatible to fzf:
1. If multi-selection is not enabled, select current item
2. If multi-selection is enabled
    a) No item is selected -> select current item
    b) already selected some items -> exclude current item
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants