Skip to content

Commit

Permalink
Use static URL to download assets from latest release (kubernetes-sig…
Browse files Browse the repository at this point in the history
…s#513)

* Use static URL to download assets from latest release

This also simplifies the release process for krew, because the version
number does not need to be updated when releasing a new version.

* Create release commit instead of tagging a random one
  • Loading branch information
corneliusweig authored Feb 28, 2020
1 parent 72774ce commit 9b5620c
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 9 deletions.
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ Check out the list of [kubectl plugins available on krew][list] or just run
```sh
(
set -x; cd "$(mktemp -d)" &&
curl -fsSLO "https://github.com/kubernetes-sigs/krew/releases/download/v0.3.4/krew.{tar.gz,yaml}" &&
curl -fsSLO "https://github.com/kubernetes-sigs/krew/releases/latest/download/krew.{tar.gz,yaml}" &&
tar zxvf krew.tar.gz &&
KREW=./krew-"$(uname | tr '[:upper:]' '[:lower:]')_amd64" &&
"$KREW" install --manifest=krew.yaml --archive=krew.tar.gz &&
Expand All @@ -78,7 +78,7 @@ Check out the list of [kubectl plugins available on krew][list] or just run
```fish
begin
set -x; set temp_dir (mktemp -d); cd "$temp_dir" &&
curl -fsSLO "https://github.com/kubernetes-sigs/krew/releases/download/v0.3.4/krew.{tar.gz,yaml}" &&
curl -fsSLO "https://github.com/kubernetes-sigs/krew/releases/latest/download/krew.{tar.gz,yaml}" &&
tar zxvf krew.tar.gz &&
set KREWNAME krew-(uname | tr '[:upper:]' '[:lower:]')_amd64 &&
./$KREWNAME install \
Expand Down
11 changes: 4 additions & 7 deletions docs/RELEASING_KREW.md
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,9 @@ Krew tags versions starting with `v`. Example: `v0.2.0-rc.1`.
TAG=v0.3.2-rc.1 # <- change this
```

1. **Update installation instructions:** Version number is hardcoded in
`README.md`.
1. **Create a release commit:**

1. **Commit the changes back:**

git commit -am "Release ${TAG:?TAG required}"
git commit -am "Release ${TAG:?TAG required}" --allow-empty

1. **Push PR and merge changes**: The repository hooks forbid direct pushes to
master, so the changes from the previous step need to be pushed and merged
Expand All @@ -47,8 +44,8 @@ Krew tags versions starting with `v`. Example: `v0.2.0-rc.1`.

(Only repository administrators can directly push to master branch.)

1. **Wait until the build succeeds:** Wait for Travis CI to show green for the
build for the commit you just pushed to master branch.
1. **Wait until the build succeeds:** Wait for CI to show green for the
build of the commit you just pushed to master branch.

1. **Tag the release:**

Expand Down

0 comments on commit 9b5620c

Please sign in to comment.