Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[webhook] clarify content of msg, heartbeatJSON and monitorJSON #4205

Open
1 task done
clement-igonet opened this issue Dec 10, 2023 · 3 comments
Open
1 task done
Labels
area:notifications Everything related to notifications feature-request Request for new features to be added help wanted May need your help to test or answer type:enhance-existing feature wants to enhance existing monitor

Comments

@clement-igonet
Copy link

clement-igonet commented Dec 10, 2023

⚠️ Please verify that this feature request has NOT been suggested before.

  • I checked and didn't find similar feature request

🏷️ Feature Request Type

New Notification

🔖 Feature description

I'm interested in customizing webhook notification with suggested msg, heartbeatJSON and monitorJSON

However, their content is not clear to me. When I look at the source code, I can see part of indications, but I'm not sure I reach the whole content. More documentation would be helpful and welcome.

For instance, is there a way to get a unique ID / fingerprint for a given up and down sequence ?

  • Indeed, it would help a lot when sending the notification up or down to third party services that need it to know how to close an incident by a unique up/down reference.

✔️ Solution

Add inline documentation in webhook notification setup, or at least fill a content as a Test notification to see a whole heartbeatJSON or monitorJSON structure and content.

❓ Alternatives

No response

📝 Additional Context

No response

@clement-igonet clement-igonet added the feature-request Request for new features to be added label Dec 10, 2023
@CommanderStorm CommanderStorm added the area:monitor Everything related to monitors label Dec 10, 2023
@CommanderStorm
Copy link
Collaborator

#3636 improved the documentation a bit, but currently this is difficult because some monitors have different information available.

Adding monitorJSON to the the test notification is something that we have not got around to yet.

If you have more concrete ideas how we can do this we would be very open to this ^^

Note that webhooks can be tested using https://webhook.site/

@CommanderStorm CommanderStorm added the help wanted May need your help to test or answer label Dec 10, 2023
@CommanderStorm CommanderStorm changed the title Customized webhook Notification: clarify content of msg, heartbeatJSON and monitorJSON Customized webhook Notification: clarify content of msg, heartbeatJSON and monitorJSON Dec 10, 2023
@CommanderStorm CommanderStorm added area:notifications Everything related to notifications type:enhance-existing feature wants to enhance existing monitor and removed area:monitor Everything related to monitors labels Dec 10, 2023
@CommanderStorm CommanderStorm changed the title Customized webhook Notification: clarify content of msg, heartbeatJSON and monitorJSON [webhook] clarify content of msg, heartbeatJSON and monitorJSON Dec 13, 2023
@joy4eg
Copy link

joy4eg commented Jun 16, 2024

currently this is difficult because some monitors have different information available.

Yeah, that's understandable. But I think they all (should?) share some common information/fields. Like name, status or host.
It would be really nice to see them (common fields) in the test notification run.

@unlimitedsola
Copy link

Stumbled upon this. I'm shocked by how little documentation on the detailed structure of the heardbeatJSON and monitorJSON is.

Note that webhooks can be tested using https://webhook.site/

This would definitely be very helpful if the "test" button doesn't simply send null values.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:notifications Everything related to notifications feature-request Request for new features to be added help wanted May need your help to test or answer type:enhance-existing feature wants to enhance existing monitor
Projects
None yet
Development

No branches or pull requests

4 participants