From 6b560f7a85974cb0906234c6220a7e27e8753adb Mon Sep 17 00:00:00 2001 From: Lovell Fuller Date: Tue, 24 Sep 2019 22:25:58 +0100 Subject: [PATCH] Remove imagemagick-native module from benchmarks Unmaintained, does not compile with newer ImageMagick and Node --- docs/performance.md | 2 -- test/bench/package.json | 1 - test/bench/perf.js | 45 ----------------------------------------- 3 files changed, 48 deletions(-) diff --git a/docs/performance.md b/docs/performance.md index 2f7d65555..6dea70dd9 100644 --- a/docs/performance.md +++ b/docs/performance.md @@ -10,7 +10,6 @@ * [jimp](https://www.npmjs.com/package/jimp) v0.5.3 - Image processing in pure JavaScript. Provides bicubic interpolation. * [mapnik](https://www.npmjs.org/package/mapnik) v4.0.1 - Whilst primarily a map renderer, Mapnik contains bitmap image utilities. -* [imagemagick-native](https://www.npmjs.com/package/imagemagick-native) v1.9.3 - Wrapper around libmagick++, supports Buffers only. * [imagemagick](https://www.npmjs.com/package/imagemagick) v0.1.3 - Supports filesystem only and "*has been unmaintained for a long time*". * [gm](https://www.npmjs.com/package/gm) v1.23.1 - Fully featured wrapper around GraphicsMagick's `gm` command line utility. * sharp v0.21.0 / libvips v8.7.0 - Caching within libvips disabled to ensure a fair comparison. @@ -28,7 +27,6 @@ then compress to JPEG at a "quality" setting of 80. | jimp | buffer | buffer | 0.71 | 1.0 | | mapnik | buffer | buffer | 3.32 | 4.7 | | gm | buffer | buffer | 3.97 | 5.6 | -| imagemagick-native | buffer | buffer | 4.06 | 5.7 | | imagemagick | file | file | 4.24 | 6.0 | | sharp | stream | stream | 25.30 | 35.6 | | sharp | file | file | 26.17 | 36.9 | diff --git a/test/bench/package.json b/test/bench/package.json index c065350eb..4b9eea83a 100644 --- a/test/bench/package.json +++ b/test/bench/package.json @@ -12,7 +12,6 @@ "benchmark": "^2.1.4", "gm": "^1.23.1", "imagemagick": "^0.1.3", - "imagemagick-native": "^1.9.3", "jimp": "^0.6.4", "mapnik": "^4.2.1", "semver": "^6.1.2" diff --git a/test/bench/perf.js b/test/bench/perf.js index 74cf60abe..32bb29e9e 100644 --- a/test/bench/perf.js +++ b/test/bench/perf.js @@ -12,12 +12,6 @@ const gm = require('gm'); const imagemagick = require('imagemagick'); const mapnik = require('mapnik'); const jimp = require('jimp'); -let imagemagickNative; -try { - imagemagickNative = require('imagemagick-native'); -} catch (err) { - console.log('Excluding imagemagick-native'); -} const fixtures = require('../fixtures'); @@ -126,29 +120,6 @@ async.series({ }); } }); - // imagemagick-native - if (typeof imagemagickNative !== 'undefined') { - jpegSuite.add('imagemagick-native-buffer-buffer', { - defer: true, - fn: function (deferred) { - imagemagickNative.convert({ - srcData: inputJpgBuffer, - quality: 80, - width: width, - height: height, - format: 'JPEG', - filter: 'Lanczos' - }, function (err, buffer) { - if (err) { - throw err; - } else { - assert.notStrictEqual(null, buffer); - deferred.resolve(); - } - }); - } - }); - } // gm jpegSuite.add('gm-buffer-file', { defer: true, @@ -698,22 +669,6 @@ async.series({ }); } }); - // imagemagick-native - if (typeof imagemagickNative !== 'undefined') { - pngSuite.add('imagemagick-native-buffer-buffer', { - defer: true, - fn: function (deferred) { - imagemagickNative.convert({ - srcData: inputPngBuffer, - width: width, - height: height, - format: 'PNG', - filter: 'Lanczos' - }); - deferred.resolve(); - } - }); - } // gm pngSuite.add('gm-file-file', { defer: true,