chore: update to capacitor 5 #55
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR, I'm no longer using Capacitor so your contribution comes in very handy. What do you mean with, "I couldn't fully test the plugin"? |
lovetodream
reviewed
Aug 21, 2023
You're welcome :) Thanks for still responding here.
I never developed a capacitor plugin before, so I simply ran the install/update commands and checked for compilation errors with the IDE, but I did not check if you have written any test cases (or wrote any myself).
I saw other plugins (those from capawesome) using this method, so that the major version of the plugin corresponds to the major version of capacitor. |
lovetodream
approved these changes
Aug 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As described in issue #54.
I ran the migration script and
npm install, however i could not fully test the plugin.