Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for query timeout #39

Closed
ghivert opened this issue Oct 3, 2024 · 3 comments · Fixed by #47
Closed

Add support for query timeout #39

ghivert opened this issue Oct 3, 2024 · 3 comments · Fixed by #47

Comments

@ghivert
Copy link
Contributor

ghivert commented Oct 3, 2024

Hi!

Currently we have no way to customise the query timeout. According to pgo#50, it should be easy to add timeout, and we could do this in a nice way.
I'd be happy to submit a PR for the feature, but I think we could gain to design a nice API.

Do you have any opinion on the subject?

@lpil
Copy link
Owner

lpil commented Oct 9, 2024

Yes lets get this done for sure.

I want to rework the whole API of this package, so I'm open to any ideas. I was likely going to use a builder API.

@ghivert
Copy link
Contributor Author

ghivert commented Oct 15, 2024

Builder API for what part of the API exactly? The connection? The query execution?
I struggle a bit finding out what part of the API you're not happy with.

@lpil
Copy link
Owner

lpil commented Oct 16, 2024

The whole API. I think currently it's a bit awkward for most uses and it's hard to extend presently.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants