Skip to content

Commit

Permalink
Roll forward bazelbuild@1fdc628: default --incompatible_config_settin…
Browse files Browse the repository at this point in the history
…g_private_default_visibility to true

This was rolled back in bazelbuild@d4fc6db
due to failing Bazel downstream tests. I fixed as many as I was aware of: see latest comments on bazelbuild#12933.

Fixes bazelbuild#12933.

PiperOrigin-RevId: 485694298
Change-Id: Ie38ce2f6cdbf952a208de37a96658770004b2bf8
  • Loading branch information
gregestren authored and Lucas Ripoche committed Jun 13, 2023
1 parent 69ca555 commit 63e1fed
Showing 1 changed file with 3 additions and 1 deletion.
Original file line number Diff line number Diff line change
Expand Up @@ -136,7 +136,9 @@ public ParallelismConverter() throws OptionsParsingException {

@Option(
name = "incompatible_config_setting_private_default_visibility",
defaultValue = "false",
// TODO(b/179944632): remove this flag when all repos work with this=true +
// --incompatible_enforce_config_setting_visibility=true.
defaultValue = "true",
documentationCategory = OptionDocumentationCategory.STARLARK_SEMANTICS,
effectTags = {OptionEffectTag.LOADING_AND_ANALYSIS},
metadataTags = {OptionMetadataTag.INCOMPATIBLE_CHANGE},
Expand Down

0 comments on commit 63e1fed

Please sign in to comment.