Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Programming exercises, Assessment: Unnecessary empty space below tutor comments #6367

Closed
b-fein opened this issue Mar 21, 2023 · 2 comments · Fixed by #7099
Closed

Programming exercises, Assessment: Unnecessary empty space below tutor comments #6367

b-fein opened this issue Mar 21, 2023 · 2 comments · Fixed by #7099

Comments

@b-fein
Copy link
Contributor

b-fein commented Mar 21, 2023

Describe the bug

There is quite a bit of empty space below inline code editor comments. The actual amount of space seems to differ based on some browser/font settings per user.

To Reproduce

  1. Assess a programming exercise submission and add inline comments.

Expected behavior

There is less empty space below inline comments.

Screenshots

The actual amount of empty lines seems to be minimum one, but up to three depending on the system font settings. The space without line number could be reduced/removed.

Screenshot 2023-03-21 at 15-25-36 Programming Exercises
rect3148

Which version of Artemis are you seeing the problem on?

6.1.1

What browsers are you seeing the problem on?

Microsoft Edge, Firefox

Additional context

No response

Relevant log output

No response

@pal03377
Copy link
Contributor

@pal03377
Copy link
Contributor

  • There also is (still) an issue where when you have the instructions / the file browser open initially and then close it, the height of the feedback card is changed, but the reserved space within the editor is not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants