Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CSRF token #9295

Open
1 task
janthoXO opened this issue Sep 7, 2024 · 0 comments
Open
1 task

Add CSRF token #9295

janthoXO opened this issue Sep 7, 2024 · 0 comments
Assignees
@janthoXO
Labels
enhancement priority:high security Pull requests that address a security vulnerability server Pull requests that update Java code. (Added Automatically!)

Comments

@janthoXO
Copy link
Contributor

janthoXO commented Sep 7, 2024 •
edited
Loading

Is your feature request related to a problem?

The VSCode plugin embeds artemis in an iframe. for the website to still function in the iframe and use the cookie correctly the sameSite attribute has to be set to none. This could impose a security risk.

Describe the solution you'd like

To make the cookie nevertheless secure, a csrf token should be implemented. Even without sameSite=none the token adds additional security
@janthoXO janthoXO added enhancement security Pull requests that address a security vulnerability server Pull requests that update Java code. (Added Automatically!) labels Sep 7, 2024
@janthoXO janthoXO self-assigned this Sep 7, 2024
@janthoXO janthoXO linked a pull request Sep 7, 2024 that will close this issue
Development: Test VSCode plugin support #8840
Closed
@coderabbitai coderabbitai bot mentioned this issue Oct 1, 2024
Closed
29 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@janthoXO janthoXO

Labels
enhancement priority:high security Pull requests that address a security vulnerability server Pull requests that update Java code. (Added Automatically!)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Development: Test VSCode plugin support ls1intum/Artemis
1 participant
@janthoXO