-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Assessment
: Add internal assessment notes for tutors
#8174
Conversation
…utor-assessment-container.component.ts Co-authored-by: Lucas Welscher <ga53foy@mytum.de>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm now
73bfd75
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approach after import changes
Checklist
General
Server
Client
Changes affecting Programming Exercises
Motivation and Context
Closes #1402.
Description
A new object
AssessmentNote
is added to results. This object has a OneToOne mapping with the creator, a createdDate and string to represent the note itself. The result has a OneToMany relationship with the AssessmentNote, which is in fact an artificial OneToOne relationship, but the other annotation is needed to make lazy fetching work. The assessment notes have no reference to their owning result.Note: There are many changes on the client-side since the way the save/submit of the assessment was handled is/was implemented slightly differently per exercise type. This PR additionally makes this as uniform as possible in the scope of this PR. There may be a possible future refactoring opportunity to deduplicate some of the previous implementations. This is out-of-scope for this PR, though.
Steps for Testing
Prerequisites:
Testing session steps start here!
Testserver States
Note
These badges show the state of the test servers.
Green = Currently available, Red = Currently locked
Review Progress
Performance Review
Code Review
Manual Tests
Test Coverage
Screenshots
@coderabbitai ignore