Various quality of life enhancements #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d using tty, update README
This was
linked to
issues
Apr 30, 2023
|
Docker apparently uses a |
Mtze
requested changes
May 2, 2023
Co-authored-by: Matthias Linhuber <github@linhuber.org>
Mtze
approved these changes
May 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed: Switched to a different node image for the docker container, README now specifies to run the docker image in interactive mode with TTY (flags -ti), Angular now serves app in development instead of production mode.
Why the change: The switch to a different node image is to try to shorten the container startup time, the non-slim bullseye image seems to build the application a bit faster although this should be tested even more, the -ti flag enables stopping of the container using control + C, starting in development mode gets rid of a warning regarding the
webpack-dev-server(although a different warning still persists regarding --disable-host-check being a security risk, however removing this option displays a different warning).Testing steps: Download the appropriate image and run it using the new command from the README with the -ti flag, confirm that the warning regarding running the app in production mode no longer shows, time how long it takes Angular to prepare the application (shouldn't be much longer than 2 minutes, depends on your architecture though), check (just to be safe) that the application does run/is accessible in the browser, confirm that stopping the container is possible via control + C in the command line.