Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default colours used #562

Open
meain opened this issue Oct 8, 2021 · 8 comments
Open

Change default colours used #562

meain opened this issue Oct 8, 2021 · 8 comments
Labels
kind/discussion Discussion on a change/addition of a feature

Comments

@meain
Copy link
Member

meain commented Oct 8, 2021

Now that #452 is merged, users should be able to change the colors for lsd to what they like. That said, I was thinking we should probably consider changing the default colors that lsd uses to work in both light and dark colorschems. Using colors less that 16 and avoiding yellow should more or less take care of that. This change is only necessary in the non filename blocks as the filename ones are already using colors from lscolors which works in both cases. This will require changes in user,group and size blocks.

My only concern here is that existing users will have a change in colors if they are not using a custom theme(it a bit better now that they can change back). Just posting it here to get other's thoughts.

@meain meain added the kind/discussion Discussion on a change/addition of a feature label Oct 8, 2021
@zwpaper
Copy link
Member

zwpaper commented Oct 8, 2021

IMHO, I think we can ship two themes by default, one for dark mode and the other for light.

it became a common case with built-in dark mode and light mode in modern OSs, I think we could catch up with it.

an option like --theme dark/light may be great in my thought, we can go even further by detecting the dark/light mode and switch automatically.

@zwpaper
Copy link
Member

zwpaper commented Oct 8, 2021

so that we will not break the user experience and be compatible with light background.

it also not easy to find a default theme fitting both dark and light mode, IMHO

@meain
Copy link
Member Author

meain commented Oct 8, 2021

Makes sense, lets go with a --color-theme flag.

About auto detection, I am not sure if we will have a simple way to do dark mode/light mode detection in terminals though. OS level theme detection might not be that reliable as a lot of people use light mode in the OS but dark colors in terminals.

@zwpaper
Copy link
Member

zwpaper commented Oct 8, 2021

totally agree, the auto-detection part needs to be discussed more and let's go with the --color-theme first!

@marchank0
Copy link

--color-theme is not implemented for now, right?

@meain
Copy link
Member Author

meain commented Dec 1, 2022

While we did not add a flag for this, we have added support to change colors via config file.

@meain
Copy link
Member Author

meain commented Feb 3, 2023

#365 (comment) This is the closest to the colors in the screenshot in README. Adding it here for reference.

@haohanyuzmx
Copy link

Is there any plane to support built-in mode, and auto switch theme by system. (like bat do)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/discussion Discussion on a change/addition of a feature
Projects
None yet
Development

No branches or pull requests

4 participants