-
-
Notifications
You must be signed in to change notification settings - Fork 447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
--icon-theme unicode showing only questionmarks #595
Comments
did some investigation, looks like a bug, |
Hi @mcaubrey, thanks for the report, but It seems that you were facing a different problem with the font, lsd have to use a patched font with emoji support, please check https://github.com/Peltoche/lsd#prerequisites. |
Thanks! I'll check that out. |
@zwpaper |
Just gentle reminder that the original issue was actually not the same as that of @mcaubrey and the fix for his problem did not fix the original problem. |
Hi @Mellbourn, sorry for the later reply, I finally found out that the Unicode we used in lsd is version 7.0, and it may have some render problems. I can reproduce it on my mac, but not yet figured out how to render the 7.0 unicode. for example:
BUT! please notice, unicode icon theme is not well implemented, we only have the file and folder icons. @meain how about we change the default Unicode back to version 6, it may add much more compatibility to lsd. also, BTW, I am trying to work on the icon theme, I may leave a seat for unicode theme, then it will have a chance to create a custom unicode icon theme. |
Just a personal opinion, switching to |
although I am not one of the target users, the Unicode option is designed to act like that with colorful glyphs? check starship for example |
I think if we can stick to non color glyphs, it would be better. But since |
IMHO, Unicode is act more like another option according to the the real problem like this issue is that we are now offering a non-functional feature |
I see your point, but I am still not yet fully convinced that adding color glyphs is the best approach (Apart from changing the looks, I have seen quite a few terminal emulators having issues with rendering multi-color emojis, but I guess those will just render monochrome versions). Let me take another look into this in the coming days and we can finalize one something. |
I think we will leave the unicode icons as is. The original issue was around being able to use emojis (colorful unicode icons) as icons in lsd. That I think would be covered once we have #707 . |
Hi, thanks for a great tool!
lsd
is working well for me with Nerd Fonts set up.However, it might be even prettier if it actually used the colorful unicode icons, e.g. 📁.
I would have guessed that
lsd --icon-theme unicode
would achieve that, but it only shows question marks for me:This is
lsd
0.20.1 installed usingbrew
on macOS Big Sur 11.6.1 (running on an m1 MacBook) running inside iTerm2 3.4.12 (but it behaves the same in Terminal 2.11).I am able to display unicode icons using
echo
Is this a bug, or is there some configuration I need to do?
The text was updated successfully, but these errors were encountered: