(fleet/cert-manager) add CertManagerCertificateReadyStatus alert #338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbegyn
approved these changes
May 3, 2024
There was a problem hiding this comment.
LGTM, but we might wanna allign all the labels before merging these requests. Alertwise and query wise these seem alright.
Generally we use summary annotations to create a description that is global without any template variables in it, while description annotations will contain specific information about the alert with template variables in it. This allows for a large group of alerts to be grouped together an announced by the summary annotation.
fbegyn
force-pushed
the
IT-5176/certmanagercertificatereadystatus
branch
from
10c87b5
to
53aa0b1
Compare
jhoblitt
force-pushed
the
IT-5176/certmanagercertificatereadystatus
branch
from
53aa0b1
to
19a3b58
Compare
jhoblitt
force-pushed
the
IT-5176/certmanagercertificatereadystatus
branch
from
19a3b58
to
7560bb4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.